fix: forward environment variables to browser subprocess #370
+8
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When launching browsers with Playwright, environment variables like DISPLAY
were not being forwarded to the browser subprocess. This caused --headed
mode to fail on Linux with virtual displays (Xvnc, Xvfb).
The fix adds `env: { ...process.env }` to all browser launch calls:
- launcher.launch() for regular ephemeral browsers
- launcher.launchPersistentContext() for extension and profile modes
Fixes vercel-labs#369
Related: vercel-labs#155, vercel-labs#150
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
|
@tounano is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
This was referenced Feb 4, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
envoption--headedmode on Linux with virtual displays (Xvnc, Xvfb)env: { ...process.env }to all 3 browser launch pathsProblem
When using
--headedmode on Linux with a virtual display, the browser fails to launch because theDISPLAYenvironment variable is not forwarded to the Chromium subprocess. Without theenvoption, Playwright doesn't pass any environment variables to the browser process.Error:
Missing X server or $DISPLAYSolution
Pass
env: { ...process.env }to Playwright's launch options:launcher.launch()for regular ephemeral browserslauncher.launchPersistentContext()for extension modelauncher.launchPersistentContext()for profile modeTest plan
pnpm typecheckpassespnpm format:checkpassespnpm testpasses (203 tests)Fixes #369
Related: #155, #150
🤖 Generated with Claude Code